Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PHP versions from GitHub Actions, fix the documentation link #26

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Remove PHP versions from GitHub Actions, fix the documentation link #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/workflows/phpunit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
on:
push:
branches:
- master
- '*.*'
pull_request: null

Expand All @@ -13,7 +12,5 @@ jobs:
with:
os: >-
['ubuntu-latest']
php: >-
['8.1', '8.2']
stability: >-
['prefer-stable']
3 changes: 0 additions & 3 deletions .github/workflows/psalm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
on:
push:
branches:
- master
- '*.*'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The branch trigger has been updated to '*.*', which might not behave as intended if the goal was to trigger on all branches. This pattern matches branches with a dot in their names, potentially excluding branches named without dots, such as main or develop.

Consider using '**' to include all branches if that's the intended behavior.

pull_request: null

Comment on lines 1 to 6
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [4-12]

The removal of the PHP version configuration is not directly shown, but its absence could lead to the workflow running on the default PHP version provided by the ubuntu-latest environment. This might not align with the project's PHP version requirements.

Consider specifying the PHP version explicitly or ensuring the default version meets the project's needs.

Expand All @@ -13,5 +12,3 @@ jobs:
with:
os: >-
['ubuntu-latest']
php: >-
['8.1']
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ application.

## Documentation

You can find more information about RoadRunner GRPC plugin in the [official documentation](https://roadrunner.dev/docs/plugins-grpc).
You can find more information about RoadRunner GRPC plugin in the [official documentation](https://docs.roadrunner.dev/plugins/grpc).

## Example

Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
],
"homepage": "https://roadrunner.dev/",
"support": {
"docs": "https://roadrunner.dev/docs",
"docs": "https://docs.roadrunner.dev",
"issues": "https://github.com/roadrunner-server/roadrunner/issues",
"forum": "https://forum.roadrunner.dev/",
"chat": "https://discord.gg/V6EK4he"
Expand Down
Loading