-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
End span in DELETE function #62
Conversation
Signed-off-by: Vladimir Plakhotnikov <embargo2710@gmail.com>
WalkthroughThe update to the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ? TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- kv/driver.go (1 hunks)
Additional comments: 1
kv/driver.go (1)
- 228-228: The addition of
defer span.End()
ensures that the span is properly closed, which is a good practice for managing the lifecycle of spans in tracing. This change correctly addresses the bug described in the PR objectives.
Hey @Kaspiman 👋 |
Thanks @Kaspiman 👍 |
Reason for This PR
Span does not closed properly.
Description of Changes
Defer end in DELETE function.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.
PR Checklist
[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]
git commit -s
).CHANGELOG.md
.Summary by CodeRabbit