Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release v2023.3.9 #1835

Merged
merged 2 commits into from
Jan 11, 2024
Merged

chore: release v2023.3.9 #1835

merged 2 commits into from
Jan 11, 2024

Conversation

rustatian
Copy link
Member

@rustatian rustatian commented Jan 11, 2024

Reason for This PR

  • Bugfix release cycle.

Description of Changes

πŸš€ v2023.3.9 πŸš€

HTTP plugin

  • πŸ›οΈ Streaming responses can experience a lock-up when the client disconnects early, BUG

SQS JOBS driver

  • πŸ›οΈ Use user specified credentials if they are set even if we're inside AWS, BUG

Server plugin

  • πŸ”₯ Add user param to on_init command section. PR, docs

Services plugin

  • πŸ›οΈ Services directly killed when restarting on terminating. BUG

Redis KV driver

  • πŸ›οΈ Correctly finish the OTEL span. PR

🧹 Chore:

  • πŸ§‘β€πŸ­ Dependencies: update project/system dependencies.
  • πŸ§‘β€πŸ­ Docs: update docs, BUG.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

Summary by CodeRabbit

  • Bug Fixes

    • Resolved issues in HTTP plugin.
    • Addressed bugs in SQS JOBS driver.
    • Fixed errors in Services plugin.
    • Corrected problems with Redis KV driver.
  • Chores

    • Updated dependencies.
    • Enhanced documentation.

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@rustatian rustatian added the C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. label Jan 11, 2024
@rustatian rustatian added this to the v2023.3.9 milestone Jan 11, 2024
@rustatian rustatian requested a review from wolfy-j January 11, 2024 13:25
@rustatian rustatian self-assigned this Jan 11, 2024
Copy link
Contributor

coderabbitai bot commented Jan 11, 2024

Walkthrough

The version 2023.3.9 release includes bug fixes for the HTTP plugin, SQS jobs driver, Services plugin, and Redis key-value driver. These fixes enhance the reliability and performance of network handling, job management, service functionality, and data storage. Additionally, routine chores have been carried out with updates to dependencies and documentation, ensuring a more robust and well-documented release.

Changes

Files/Components Change Summary
HTTP plugin Bug fixes for improved reliability
SQS JOBS driver Bug fixes for enhanced job handling
Services plugin Bug fixes for improved service functionality
Redis KV driver Bug fixes for enhanced data storage
Dependencies & Docs Chore updates for improved maintenance

πŸ‡βœ¨
A hop, a skip, in the code we dive,
Bugs to fix, so our plugins thrive.
With each release, we patch and we mend,
To ensure all your services smoothly extend. 🌟

(\__/) ||
(β€’γ……β€’) ||
/ γ€€ γ₯

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (7358357) 37.29% compared to head (ce58553) 37.29%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1835   +/-   ##
=======================================
  Coverage   37.29%   37.29%           
=======================================
  Files          16       16           
  Lines         866      866           
=======================================
  Hits          323      323           
  Misses        517      517           
  Partials       26       26           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 7358357 and e16d3ca.
Files ignored due to filter (2)
  • go.mod
  • go.sum
Files selected for processing (1)
  • CHANGELOG.md (2 hunks)
Additional comments: 6
CHANGELOG.md (6)
  • 3-7: The entry for the HTTP plugin correctly references the bug fix and includes a link to the issue. The acknowledgment of the contributor is also present.

  • 9-11: The SQS JOBS driver section mentions the bug fix and the use of user-specified credentials, with a link to the issue and contributor acknowledgment.

  • 13-15: The Services plugin section details the fix for the service termination issue during restarts, links to the issue, and acknowledges the contributor.

  • 17-19: The Redis KV driver section notes the improvement made for the OTEL span and references the external PR in the Redis repository, including contributor acknowledgment.

  • 21-25: The chore section lists updates to dependencies and documentation, with a specific mention of a documentation bug fix linked to an issue.

  • 3-27: The summary for the v2023.3.9 release in the CHANGELOG.md appears to be complete and accurate, reflecting the changes mentioned in the PR objectives and the AI-generated summary. However, it would be beneficial to verify that all user-facing changes are indeed documented in the CHANGELOG.md as per the PR checklist.

Verification successful

The extended context from the CHANGELOG.md confirms that the release notes for v2023.3.9 include the user-facing changes for the HTTP plugin, SQS JOBS driver, Services plugin, and Redis KV driver, as well as the chore updates for dependencies. This matches the PR objectives and the AI-generated summary, verifying that the CHANGELOG.md accurately reflects the changes made in this release.

Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Verify that all user-facing changes are documented in the CHANGELOG.md
rg --type md "v2023.3.9" CHANGELOG.md
# Expecting to see all the user-facing changes listed under the v2023.3.9 section.

Length of output: 74



Script:

#!/bin/bash
# Verify that all user-facing changes are documented in the CHANGELOG.md by showing several lines of context after the match
rg --type md -C 10 "v2023.3.9" CHANGELOG.md
# Expecting to see all the user-facing changes listed under the v2023.3.9 section with some context.

Length of output: 498



Script:

#!/bin/bash
# Verify that all user-facing changes are documented in the CHANGELOG.md by showing the entire section for v2023.3.9
rg --type md -C 20 "v2023.3.9" CHANGELOG.md
# Expecting to see the complete list of user-facing changes for the v2023.3.9 release.

Length of output: 882

CHANGELOG.md Show resolved Hide resolved
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between e16d3ca and ce58553.
Files selected for processing (1)
  • CHANGELOG.md (2 hunks)
Files skipped from review as they are similar to previous changes (1)
  • CHANGELOG.md

@rustatian rustatian merged commit 362f643 into master Jan 11, 2024
14 checks passed
@rustatian rustatian deleted the release/v2023.3.9 branch January 11, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant