-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Also require the order ID in the delivery message #1
Conversation
When delivering a product, the robot now also needs to send the ID of the order that the product belongs to.
7cf2a66
to
974dd6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we change this sentence:
[...] points can only be scored if the DS was properly prepared before (means the corresponding delivery
lane which was desired in the refbox order) [...]
to:
[...] points can only be scored if the DS was properly prepared before (means the corresponding order ID
[and lane which was desired in the refbox order]) [...]
Since we are submitting the order ID, we would not need to specify the lane anymore? Anyhow, we should award points (automatically!) only if the order ID is specified
Make clear that points are only given for delivery if the order ID was set beforehand.
Thanks for pointing that out. I rephrased that paragraph to make clear that points are only given if the DS was prepared with an order ID. I haven't removed the lane. From my side, we can keep it or drop it completely from the prepare message. It's not really necessary anymore, but it also doesn't do any damage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
When delivering a product, the robot now also needs to send the ID of
the order that the product belongs to.
This idea was discussed at TC meeting 2/19.