Remove gate from DS prepare message #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The prepare message is explained later again, no need to state the necessary information twice.
morxa
requested review from
dka14,
MostafaGomaa,
teamsolidus,
thomerz,
timn and
vcoelen
as code owners
|
+1 |
thomerz
approved these changes
Jan 31, 2019
|
+1 |
1 similar comment
|
+1 |
MostafaGomaa
approved these changes
Jan 31, 2019
|
+1 |
1 similar comment
|
+1 |
|
Proposal accepted
|
morxa
added
accepted-rule-change
morxa
referenced
this pull request
in robocup-logistics/rcll-refbox
Apr 4, 2020
Mark the slot id and name as reserved so they won't be re-used on accident.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed at today's TC meeting, we no longer want the gate to be part of the DS prepare message. We already have the order ID (since #1), therefore sending the gate is redundant.
Also remove some redundant information in the rulebook about DS preparation to avoid inconsistencies.