Skip to content

osgar.zmqrouter: replace popen with forkserver #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

osgar.zmqrouter: replace popen with forkserver #602

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 16 additions & 13 deletions osgar/zmqrouter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import datetime
import logging
import signal
import subprocess
import multiprocessing
import sys
import threading
import time
Expand Down Expand Up @@ -46,15 +46,19 @@ def child(name, module_config, log_level):

def record(config, log_prefix=None, log_filename=None, duration_sec=None):
g_logger.info("recording...")
try:
mp_context = multiprocessing.get_context("forkserver")
except ValueError:
mp_context = multiprocessing.get_context()
g_logger.info(mp_context.get_start_method())
with osgar.logger.LogWriter(prefix=log_prefix, filename=log_filename, note=str(sys.argv)) as log:
log.write(0, bytes(str(config), 'ascii'))
g_logger.info(log.filename)
with _Router(log) as router:
modules = {}
s = sys.modules[__name__].__spec__
for module_name, module_config in config['robot']['modules'].items():
program = f"import {s.name}; {s.name}.child('{module_name}', {module_config}, {logging.root.level})"
modules[module_name] = subprocess.Popen([sys.executable, "-c", program])
modules[module_name] = mp_context.Process(target=child, args=(module_name, module_config, logging.root.level))
modules[module_name].start()

try:
router.register_nodes(modules.keys(), timeout=datetime.timedelta(seconds=1))
Expand All @@ -71,15 +75,14 @@ def record(config, log_prefix=None, log_filename=None, duration_sec=None):
router.request_stop(b"exception")

for module in modules.values():
try:
# always stop within 1s
timeout = 1 - (router.now() - router.stopping).total_seconds()
if timeout < 0:
timeout = 0
module.wait(timeout)
except subprocess.TimeoutExpired:
module.kill()
module.wait()
# always stop within 1s
timeout = 1 - (router.now() - router.stopping).total_seconds()
if timeout < 0:
timeout = 0
module.join(timeout)
if module.exitcode is None:
module.terminate()
module.join()


class _Router:
Expand Down