Support setting joint velocity limits #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegoferigo
force-pushed
the
feature/velocity_limit
branch
from
154da66 to
ee07cf8
Compare
|
I am a bit dubious in general about the semantics of velocity limits in simulations, and I am not really sure about what "This limit can be used to clip the velocity applied by joint", but this is not blocking. |
traversaro
approved these changes
May 23, 2021
|
The main use case of this feature is accessing Having hidden limits that now are picked up from the physics engine could lead to surprising results. Even if the semantics is not fully clear, at least it could make a bell ring in developers minds when checking the available methods (or the documentation). |
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows gazebo-forks/dart#17 (that follows dartsim/dart#1407).