Fully qualify BlockTestCore::execution to avoid confusion with std::execution #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix robotology/robotology-superbuild#1646 .
This is a good example on why it is important not too use to much statements such as
using namespace std
. In blocktest,BlockTestCore::execution
is defined, while since C++17 in the STLstd::execution
is defined.The problem is hidden until someone includes (even transitively, that I guess it is why at the moment we have this feature only on a specific macos image) the
<algorithm>
headers that definesstd::execution
, and then you get errors like:A more complete cleanup would be to try to avoid
using namespace std
, but at first I got a simple fix to the CI happy again.