-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[plugins][maissensor] Fix discrepancy of MAIS analog sensor between simulation and real robot #502
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect this will break CER simulation, where mais output is expressed in degrees and not 0-255.. Investigation is required before merging...
Can we revise these modifications in such a way that they can be made configurable? |
If ok, I can add a parameter to specify the format of the output. And, not to break the current status, to have by default the output in degrees. I though that only icub robots were using this plugin also because there was a hardcoded
which, btw, I changed to 15 within this PR as that is the number of channels we are expecting on icub robots (according to the icub wiki). [edit by @randaz81: see related issue https://github.com/robotology-legacy/icub-gazebo-legacy/issues/81] |
If urgent, a parameter is ok as a temporary fix because, unfortunately, I think we need some time to investigate an optimal solution. |
…real robot, of mais analog sensorsoutput Output is constrained to be between 0 and 255, the former is reached when the joint is at its maximum value, the latter when the joint is at its minimum value
After some additional reasoning, I come out with the idea that the fixes suggested by Nicola are right: the plugin in gazebo must reflect as much as possible the implementation on the real hardware. In this case iCub is ok, while R1 implementation is contrived and it needs some refactoring. Please proceed with this PR, I'll take care of the fixes required on R1. |
3415103
to
e6f2928
Compare
Fixed mismatched behavior, with respect to the real robot, of MAIS analog sensors output
Output is constrained to be between 0 and 255, the former is reached when the joint is >= maximum value, the latter when the joint is <= its minimum value
Maximum and minimum values are obtained from Gazebo hw limits.
Fixes #476