Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up branches of HDE #101

Closed
9 tasks done
lrapetti opened this issue Apr 11, 2019 · 17 comments
Closed
9 tasks done

Clean up branches of HDE #101

lrapetti opened this issue Apr 11, 2019 · 17 comments

Comments

@lrapetti
Copy link
Member

lrapetti commented Apr 11, 2019

GIven the last activities of Cleaning HDEv2 we deprecated Human-Dynamics-Estimation version 1.

I think it would be good to take the opportunity to archive all the stale branches in robotology/human-dynamics-estimation that were implemented on top of HDEv1:

  • feature/floatingBase
  • demo/AnDyY1
  • feature/floating_base
  • imu_lin_acc_in_y
  • human_joint_acc_in_y
  • all_accelerations_in_y
  • ftShoes_only_human
  • clang-format
  • release/HDEv2

@Yeshasvitvs @diegoferigo @claudia-lat
Is there any particular concern with any of those branches.

CC @traversaro @DanielePucci

@lrapetti lrapetti added this to the Iteration 21 milestone Apr 11, 2019
@DanielePucci DanielePucci changed the title Clean up branches Clean up branches of HDE Apr 29, 2019
@DanielePucci
Copy link
Contributor

DanielePucci commented May 6, 2019

As soon as we push a working version with integration IK, we'll clean up all the branches here.

@lrapetti
Copy link
Member Author

HDEv2 is now merged (#91), I think that the branches based on HDEv1 mentioned above can be safely archived.
@Yeshasvitvs

@yeshasvitirupachuri
Copy link
Member

yeshasvitirupachuri commented Jan 27, 2020

@lrapetti @kouroshD

I would like to start the cleanup for this repo starting with the removal of stale branches as pointed out in #101 (comment). The following branches are at least one to two years old and are no longer relevant to the current code base.

Stale Branches

As agreed with @lrapetti and @kouroshD the above branches will be deleted.

@yeshasvitirupachuri
Copy link
Member

After deleting the stale branches, we need to align the other branches to stable branches that can be used for demo purposes. Currently, the code base of this repo is used along the following two research axes and for two demos. At the current state devel is the base code for all the other branches.

Teleoperation

The branch that is fully functional for showing teleoperation demos is add-secondary-calibration. So, this branch needs to be merged to the devel branch.

devel <------------ add-secondary-calibration

The other branches that are recently opened for teleoperation research axes are the following:

@kouroshD @lrapetti can you please go over these branches and check if they are still relevant to the current code base. If they are, please open appropriate PRs.

Human Dynamics Visualization

The branch that implemented the feature of external wrench estimation through stack of tasks berdy implementation is feature/visualize-berdy-estimated-wrench. A new branch that tracks the additional details of calibration done for AnDy suit video are available in new-offset-removal-options. So, the code alignment for this work is

devel <------------ feature/visualize-berdy-estimated-wrench <------------ new-offset-removal-options

@lrapetti can you please check if test_demo branch is still relevant or can we delete it.

@lrapetti
Copy link
Member Author

This two branch can be safely removed.

@yeshasvitirupachuri
Copy link
Member

Following PR #156, new-offset-removal-options branch is deleted.

@yeshasvitirupachuri
Copy link
Member

yeshasvitirupachuri commented Jan 30, 2020

The master branch is rebased on the devel branch and then merged to it fd3e904

Both the master and devel branches are aligned. I tested the devel branch and the standard HDE demo is working without any errors

ezgif com-video-to-gif

CC @lrapetti @kouroshD it is better to do a quick test for retargeting with this branch when you have time.Thanks.

@lrapetti
Copy link
Member Author

lrapetti commented Jan 31, 2020

add-secondary-calibration branch is now merged (#164) into devel, so that branch can be deleted (I would do it but it seems I don't have the rights.

I don't know if it should be merged also into master, @Yeshasvitvs how was your plan to proceede?

@traversaro
Copy link
Member

traversaro commented Feb 1, 2020

The master branch is rebased on the devel branch and then merged to it fd3e904
ll "
Guys, please avoid rebasing (and in any case avoid to use git push -f, as in all force options you are supposed to use it only if you know what it means : ) ) for public used branches, as this:

See on this https://dev.to/rkfg/comment/103c, but you can also just google "git push force on master".

This is important for everyone. @robotology/iit-dic

@yeshasvitirupachuri
Copy link
Member

[add-secondary-calibration]([https://github.com/robotology/human-dynamics-estimation/tree/add-secondary-calibration]](https://github.com/robotology/human-dynamics-estimation/tree/add-secondary-calibration%5D) branch is now merged (#164) into devel, so that branch can be deleted (I would do it but it seems I don't have the rights.

I don't know if it should be merged also into master, @Yeshasvitvs how was your plan to proceede?

There was a branch rule making the branches after PR protected. This is why you were not able to delete the branch after the PR is merged.

@yeshasvitirupachuri
Copy link
Member

I don't know if it should be merged also into master, @Yeshasvitvs how was your plan to proceede?

@lrapetti lets wait for the update on #171 to be stable. Following #174 we can get devel and master aligned again.

@DanielePucci
Copy link
Contributor

If I am not wrong, both #171 and #174 have been closed, so the alignment may take place

@claudia-lat
Copy link
Contributor

Please @kouroshD add your comment on this.

@kouroshD
Copy link
Contributor

kouroshD commented Mar 9, 2020

I backed up the branches: feature/AddQP, feature/tmpAddRetargetting,
feature/teleoperation.
In any case, they were merged already to devel, so we can remove these branches from human-dynamics-estimation.

@yeshasvitirupachuri
Copy link
Member

@kouroshD if available please add the references to the PR merges related to those branches

@yeshasvitirupachuri
Copy link
Member

Deleting the following three branches:

  • feature/AddQP
  • feature/tmpAddRetargetting
  • feature/teleoperation

@kouroshD @lrapetti @claudia-lat @DanielePucci

@yeshasvitirupachuri
Copy link
Member

Now the human-dynamics-estimation repo is rid of all the unnecessary branches. Only the following branches are maintained:

Closing this issue for now

@lrapetti @kouroshD @lrapetti @DanielePucci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants