Move MotorFaultState to EoMotionControl #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 11, 2024
valegagge
reviewed
Mar 11, 2024
MSECode
force-pushed
the
fix/diagnosticGenError
branch
from
6811535
to
31504bb
Compare
MSECode
force-pushed
the
fix/diagnosticGenError
branch
from
31504bb
to
049ea92
Compare
|
@valegagge ready for re-check |
solved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move MotorFaultState to EoMotionControl in order that we can use same type on both fw and sw.
Then add the enum typedef as guard
Change type mc_fault_state for being compliant with all definitions done in fw and sw
Related to:
robotology/icub-firmware#472
robotology/icub-main#942