Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/diagnostic gen error #472

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

MSECode
Copy link
Contributor

@MSECode MSECode commented Feb 21, 2024

Just commented part specific to masks of generic error coming from 2FOC so that all MC generic error are then translated in icub main

Related to:
robotology/icub-firmware-shared#94
robotology/icub-main#942

Copy link
Member

@valegagge valegagge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@valegagge valegagge marked this pull request as ready for review March 13, 2024 12:30
Copy link
Contributor

@marcoaccame marcoaccame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, thanks

@marcoaccame marcoaccame merged commit 97be961 into robotology:devel Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants