Feature/publish encoder raw values #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @MSECode, it is still wip, so not yet ready for review, correct? |
|
Yes exactly, I'm still reviewing some lines w/ @valegagge |
MSECode
force-pushed
the
feature/publishEncoderRawValues
branch
from
32cfe01 to
48349c0
Compare
Update ems code for publishing raw values of amo encoder Update fw to save raw values from spi encoders Update rawValuePusbliher with encoder diagnostic value in third position of data array Update with refactored and cleaned IFreader interface in embot::app::eth::encoder::experimental and added comments to structs
MSECode
force-pushed
the
feature/publishEncoderRawValues
branch
from
3e3ce83 to
aa40948
Compare
|
Opened also PR for icub-formware-build and checked the fw on a bench setup that uses AMO encoder |
marcoaccame
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add some fw to enable the publication of the raw values of joint encoders and save them in the
multiencarray.It's related to: