Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sole skin layout in configuration files and kinematic model do not match #899

Closed
BoPot opened this issue Aug 15, 2023 · 10 comments · Fixed by #912
Closed

Sole skin layout in configuration files and kinematic model do not match #899

BoPot opened this issue Aug 15, 2023 · 10 comments · Fixed by #912
Assignees

Comments

@BoPot
Copy link
Contributor

BoPot commented Aug 15, 2023

Bug description

The triangle layout in both right and left sole skin .ini files (right_foot.ini and left_foot.ini) is different from their layout in model.urdf
More precisely, the top patch is differently rotated.

@matejhof @rustlluk @traversaro

Steps to reproduce

My code for plotting taxels based on triangle positions from .ini file: read_ini.py
My code for plotting taxels based on triangle positions from .urdf file: skin_from_urdf.py

Expected behavior

No response

Example repository

No response

Additional context

Results of the visualization for left foot (see the difference in top patch):

Positions from left_foot.ini
l_sole_ini_plot

Positions from model.urdf
l_sole_urdf_plot

Also compared the visualizations to the picture inserted in ini generator left_foot_ini_generator.xlsx (see the "top" sheet). The layout there corresponds to the one in model.urdf
l_foot_ini_generator

@pattacini
Copy link
Member

@maggia80
Copy link
Contributor

@BoPot you are right there is a mismatch from the assembly notes:
AN2013_ICUB_FOOT_0001.pdf
and the ini generator file.

The position you reconstruct is the correct one wrt the real robot.

@pattacini
Copy link
Member

Hi @BoPot

We've planned to work on this fix at the beginning of September.
I think this is not blocking you anyhow.

/remind September 04.

@octo-reminder
Copy link

octo-reminder bot commented Aug 22, 2023

Reminder
Monday, September 4, 2023 10:00 AM (GMT+02:00)

.

@BoPot
Copy link
Contributor Author

BoPot commented Aug 22, 2023

Hi,
thank you for the info @maggia80 .
@pattacini No, it is not blocking me, now that I know which layout is correct, I can make the calibration. I will make a pull request once it is ready.

@rustlluk
Copy link
Contributor

rustlluk commented Aug 31, 2023

Hi all,
We have been testing position files extracted from the URDF model, and this issue may be more complicated.

Triangle IDs in our test are like this: URDF = assembly notes and .ini = real robot (iCubPrague01).
See the attached video. When touching the left foot, skinGui shows the correct movement, but visualization that uses position files extracted from URDF has the triangles in wrong order. When the triangles in position files are reordered based on triangle IDs from the .ini files, it works as expected.

So, it may be worth testing it on some of your robots before making changes to the .ini files.

iCubPrague01_left_foot.mp4

@fiorisi fiorisi assigned fiorisi and unassigned fiorisi Sep 1, 2023
@octo-reminder
Copy link

octo-reminder bot commented Sep 4, 2023

🔔 @pattacini

.

@pattacini
Copy link
Member

@simeonedussoni will be dealing with this issue during this sprint.

@pattacini
Copy link
Member

Related PR:

@pattacini
Copy link
Member

PR merged with this follow-up:

@pattacini pattacini linked a pull request Oct 30, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants