Add MotorTemperaturePublisher tool #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pattacini
requested changes
Mar 11, 2024
There was a problem hiding this comment.
Some points to address:
- Missing copyright in the code files.
- App files need to be moved to
icub-main/app. Get inspired by how it's done from one example there. - We don't use README but rather doxygen to publish documentation.
- We also need to account for the new addition by extending the
src/tools/CMakeLists.txtfile.
MSECode
force-pushed
the
feature/motorTemperaturePublisher
branch
from
b5d4c87
to
623fcba
Compare
|
pattacini
requested changes
Mar 12, 2024
There was a problem hiding this comment.
Some further comments to address, plus these general indications:
- We need also to take into consideration the update of https://github.com/robotology/icub-main/blob/master/src/tools/CMakeLists.txt#L5-L17.
- You need to provide a
CMakeLists.txtfile to install the conf files. Check out all the other app folders to have a baseline. - We need also to update the https://github.com/robotology/icub-main/blob/master/app/CMakeLists.txt
src/tools/motorTemperaturePublisher/temperatureScopeUpperArm.xml
Outdated
Show resolved
Hide resolved
src/tools/motorTemperaturePublisher/src/MotorTemperaturePublisher.cpp
Outdated
Show resolved
Hide resolved
MSECode
force-pushed
the
feature/motorTemperaturePublisher
branch
from
623fcba
to
d3d2aac
Compare
MSECode
force-pushed
the
feature/motorTemperaturePublisher
branch
from
d3d2aac
to
48e7718
Compare
pattacini
reviewed
Mar 14, 2024
Co-authored-by: Ugo Pattacini <ugo.pattacini@iit.it>
pattacini
requested changes
Mar 14, 2024
MSECode
force-pushed
the
feature/motorTemperaturePublisher
branch
from
00e512c
to
8e2424d
Compare
MSECode
force-pushed
the
feature/motorTemperaturePublisher
branch
from
8e2424d
to
60e8b64
Compare
pattacini
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add to
src/toolsa new tool calledmotorTemperaturePublisherwhich might be helpful for publishing the motor temperatures read from the ETH callback on the software. As things now the module can be started and used on a single robot subpart at the same time. So, if you need to check the temperature of multiple subparts or you start multiple instances of the application or you change theapp/conf/config.inifile each time defining underportprefixthe subpart that you need and inlistofjointsthe list of the jonts you desire to read the temperature.All other specific info about what the module does and how to build it can be found in the
README.md