icub3: fix ft frame exportation #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nicogene
force-pushed
the
fix/icub3FTFrames
branch
from
1e48307 to
2d9be48
Compare
|
FYI @GiulioRomualdi @prashanthr05 the FT sensor frame used by iDynTree will probably be wrong until this PR is merged. |
traversaro
approved these changes
Nov 24, 2020
|
After robotology/simmechanics-to-urdf#45 we probably need to bump the simmechanics-to-urdf version used in CI, right? |
Maybe it is not mandatory since it takes the latest master 🤔 |
Ah, I had no idea. Probably it is better to use a fixed version for reproducibility, but we can do it in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since in icub3 the ft frames are associated to the parent link we needed to add a functionality in
simmechanics_to_urdf. (It is harcoded that they are referenced to the child link)Then DO NOT MERGE before robotology/simmechanics-to-urdf#45
cc @pattacini @S-Dafarra