Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icub3: fix the feet's ft measurement direction #185

Merged
merged 1 commit into from
Dec 2, 2020
Merged

Conversation

Nicogene
Copy link
Member

@Nicogene Nicogene commented Dec 2, 2020

We noticed from the cad that the FT sensors in the feet are mounted upwards, and in the arms are mounted downwards, and following what the wiki states (see https://wiki.icub.org/wiki/FT_sensor) in the feet the direction are parent_to_child

Ft in the arm

immagine

Ft in the feet

immagine

Please review code

@Nicogene Nicogene added the bug label Dec 2, 2020
@Nicogene Nicogene self-assigned this Dec 2, 2020
@pattacini
Copy link
Member

cc @prashanthr05 @S-Dafarra

@traversaro
Copy link
Member

As a final check, it would be a good idea to check how the FT sensors are mounted on the iCub 2.5 (based on the yaml configuration in this repo, I would suppose that the are mounted as in the arm).

@traversaro
Copy link
Member

As a final check, it would be a good idea to check how the FT sensors are mounted on the iCub 2.5 (based on the yaml configuration in this repo, I would suppose that the are mounted as in the arm).

In any case, this can be done after the merge.

@traversaro traversaro merged commit b4d3186 into master Dec 2, 2020
@pattacini pattacini deleted the fix/icub3ftFeet branch December 2, 2020 15:01
@Nicogene
Copy link
Member Author

Nicogene commented Dec 2, 2020

As a final check, it would be a good idea to check how the FT sensors are mounted on the iCub 2.5 (based on the yaml configuration in this repo, I would suppose that the are mounted as in the arm).

Checking the yaml seems so :

https://github.com/robotology/icub-models-generator/blob/master/simmechanics/data/icub2_5/ICUB_2-5_BB_simmechanics_options.yaml.in#L610-L637

And I can confirm it also CAD side

Ft in the arms
immagine

Ft in the feet

immagine

@traversaro
Copy link
Member

traversaro commented Dec 2, 2020

So, working to have the measured_direction in SDF back in gazebosim/gazebo-classic#940 and removing the hard-coded assumption that the direction of the FT sensor was always child_to_parent that we had in iDyn turned out to be useful in the end, as at some point we used another mounting direction for our FT sensors. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants