Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune the PID controller on iCubGazeboV3 and remove not used files #189

Merged
merged 2 commits into from
Dec 11, 2020

Conversation

GiulioRomualdi
Copy link
Member

@GiulioRomualdi GiulioRomualdi commented Dec 10, 2020

This PR changes some gains of iCubGazeboV3. Thanks to that gains I was able to improve the walking performances.

Furthermore, I also remove some files that seem not to be used.

cc @Nicogene and @traversaro

@GiulioRomualdi GiulioRomualdi changed the title Tune the PID controller on iCubGenovaV3 and remove not used files Tune the PID controller on iCubGazeboV3 and remove not used files Dec 10, 2020
@traversaro traversaro requested a review from Nicogene December 10, 2020 14:26
Copy link
Member

@Nicogene Nicogene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me, except for the removal of the left/right_arm.ini files, you are right they are not used right now, but one day we will add the hands, then we will need them, thanks!

@traversaro
Copy link
Member

you are right they are not used right now, but one day we will add the hands, then we will need them, thanks!

When we will them, we can add them, right?
Otherwise in the meantime it is highly error prone to have files that we do not update and nobody is testing at all, so they could accumulate errors over time. If we ever need to see those files, we just need to go back to them (git remembers).

@traversaro
Copy link
Member

traversaro commented Dec 11, 2020

Even when we add the hands, probably it would make sense to have one single file that we use in both cases (as done for the hands), rather then duplicate information over different configuration files. But that is another story.

Copy link
Member

@Nicogene Nicogene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we will them, we can add them, right?
Otherwise in the meantime it is highly error prone to have files that we do not update and nobody is testing at all, so they could accumulate errors over time. If we ever need to see those files, we just need to go back to them (git remembers).

Yes sure, it was not a strong constraint for me, we can proceed merging

@traversaro
Copy link
Member

To clarify, I was the one that suggested to @GiulioRomualdi to delete the files, hence my explanation.

@traversaro traversaro merged commit 24a3dd7 into robotology:master Dec 11, 2020
@GiulioRomualdi GiulioRomualdi deleted the tune/icub3 branch December 11, 2020 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants