Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete iCub directory of icub-models every time the models are re-generated #236

Merged
merged 4 commits into from
Sep 15, 2023
Merged

Delete iCub directory of icub-models every time the models are re-generated #236

merged 4 commits into from
Sep 15, 2023

Conversation

traversaro
Copy link
Member

@traversaro traversaro mentioned this pull request Feb 14, 2023
Closed
@traversaro
Copy link
Member Author

I added a few prints in the CI to check before merging, and this PR will delete the following files as they are not generated anymore by icub-model-generator apparently:

 	deleted:    iCub/conf/FT/gazebo_icub_left_foot_front_ft.ini
	deleted:    iCub/conf/FT/gazebo_icub_left_foot_rear_ft.ini
	deleted:    iCub/conf/FT/gazebo_icub_right_foot_front_ft.ini
	deleted:    iCub/conf/FT/gazebo_icub_right_foot_rear_ft.ini
	deleted:    iCub/conf/gazebo_icub_head.ini
	deleted:    iCub/conf/gazebo_icub_left_arm.ini
	deleted:    iCub/conf/gazebo_icub_left_arm_no_forearm.ini
	deleted:    iCub/conf/gazebo_icub_left_arm_no_hand.ini
	deleted:    iCub/conf/gazebo_icub_left_hand.ini
	deleted:    iCub/conf/gazebo_icub_left_hand_finger.ini
	deleted:    iCub/conf/gazebo_icub_left_hand_fingers.ini
	deleted:    iCub/conf/gazebo_icub_left_hand_index.ini
	deleted:    iCub/conf/gazebo_icub_left_hand_mais.ini
	deleted:    iCub/conf/gazebo_icub_left_hand_middle.ini
	deleted:    iCub/conf/gazebo_icub_left_hand_pinky.ini
	deleted:    iCub/conf/gazebo_icub_left_hand_thumb.ini
	deleted:    iCub/conf/gazebo_icub_right_arm.ini
	deleted:    iCub/conf/gazebo_icub_right_arm_no_forearm.ini
	deleted:    iCub/conf/gazebo_icub_right_arm_no_hand.ini
	deleted:    iCub/conf/gazebo_icub_right_hand.ini
	deleted:    iCub/conf/gazebo_icub_right_hand_finger.ini
	deleted:    iCub/conf/gazebo_icub_right_hand_fingers.ini
	deleted:    iCub/conf/gazebo_icub_right_hand_index.ini
	deleted:    iCub/conf/gazebo_icub_right_hand_mais.ini
	deleted:    iCub/conf/gazebo_icub_right_hand_middle.ini
	deleted:    iCub/conf/gazebo_icub_right_hand_pinky.ini
	deleted:    iCub/conf/gazebo_icub_right_hand_thumb.ini
	deleted:    iCub/conf_icub3/MTB/gazebo_icub_left_arm_mtb.ini
	deleted:    iCub/conf_icub3/MTB/gazebo_icub_left_leg_mtb.ini
	deleted:    iCub/conf_icub3/MTB/gazebo_icub_right_arm_mtb.ini
	deleted:    iCub/conf_icub3/MTB/gazebo_icub_right_leg_mtb.ini
	deleted:    iCub/conf_icub3/MTB/gazebo_icub_torso_mtb.ini
	deleted:    iCub/conf_icub3/gazebo_icub_head.ini
	deleted:    iCub/conf_icub3/gazebo_icub_head_without_eyes.ini
	deleted:    iCub/conf_icub3/gazebo_icub_left_arm.ini
	deleted:    iCub/conf_icub3/gazebo_icub_left_arm_no_forearm.ini
	deleted:    iCub/conf_icub3/gazebo_icub_left_arm_no_hand.ini
	deleted:    iCub/conf_icub3/gazebo_icub_left_hand.ini
	deleted:    iCub/conf_icub3/gazebo_icub_left_hand_finger.ini
	deleted:    iCub/conf_icub3/gazebo_icub_left_hand_fingers.ini
	deleted:    iCub/conf_icub3/gazebo_icub_left_hand_index.ini
	deleted:    iCub/conf_icub3/gazebo_icub_left_hand_mais.ini
	deleted:    iCub/conf_icub3/gazebo_icub_left_hand_middle.ini
	deleted:    iCub/conf_icub3/gazebo_icub_left_hand_pinky.ini
	deleted:    iCub/conf_icub3/gazebo_icub_left_hand_thumb.ini
	deleted:    iCub/conf_icub3/gazebo_icub_right_arm.ini
	deleted:    iCub/conf_icub3/gazebo_icub_right_arm_no_forearm.ini
	deleted:    iCub/conf_icub3/gazebo_icub_right_arm_no_hand.ini
	deleted:    iCub/conf_icub3/gazebo_icub_right_hand.ini
	deleted:    iCub/conf_icub3/gazebo_icub_right_hand_finger.ini
	deleted:    iCub/conf_icub3/gazebo_icub_right_hand_fingers.ini
	deleted:    iCub/conf_icub3/gazebo_icub_right_hand_index.ini
	deleted:    iCub/conf_icub3/gazebo_icub_right_hand_mais.ini
	deleted:    iCub/conf_icub3/gazebo_icub_right_hand_middle.ini
	deleted:    iCub/conf_icub3/gazebo_icub_right_hand_pinky.ini
	deleted:    iCub/conf_icub3/gazebo_icub_right_hand_thumb.ini
	deleted:    iCub/conf_icub3/gazebo_icub_robotname.ini
	deleted:    iCub/conf_icub3/gazebo_icub_xsens_inertial.ini
	deleted:    iCub/conf_icub3/left_camera.ini
	deleted:    iCub/conf_icub3/right_camera.ini
	deleted:    iCub/conf_icub3/yarpmotorgui.ini
	deleted:    iCub/meshes/simmechanics/sim_icub3_head_prt.stl
	deleted:    iCub/meshes/simmechanics/sim_icub3_neck_1_prt.stl
	deleted:    iCub/meshes/simmechanics/sim_icub3_neck_2_prt.stl
	deleted:    iCub/meshes/simmechanics/sim_icub3_neck_3_prt.stl

More and less, it seems to me that they are similar to the list provided by @xEnVrE in robotology/icub-models#185 . If some files are actually needed, we should add them in icub-model-generator . @mebbaid @Nicogene do you think there is some file we still need?

@mebbaid
Copy link
Contributor

mebbaid commented Feb 15, 2023

do you think there is some file we still need?

@traversaro currently the iCubGazeboV3_visuomanip urdf refernce the following two files out of the list

  • iCub/conf_icub3/gazebo_icub_left_arm.ini
  • iCub/conf_icub3/gazebo_icub_right_arm.ini

It is perhaps not necessary, and in case we can change the urdf to reference an automatically generated one.

@traversaro
Copy link
Member Author

Good catch @mebbaid ! Probably we can move those files in https://github.com/robotology/icub-models/tree/master/iCub_manual/conf_manual/iCubGazeboV3_visuomanip ?

@mebbaid
Copy link
Contributor

mebbaid commented Feb 15, 2023

Good catch @mebbaid ! Probably we can move those files in https://github.com/robotology/icub-models/tree/master/iCub_manual/conf_manual/iCubGazeboV3_visuomanip ?

yeah, it seems ok to me.

Nicogene
Nicogene approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@Nicogene Nicogene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a similar issue in ergocub-software, probably I have to implement something similar also there, right now I am doing manual cleanups.

@traversaro
Copy link
Member Author

@mebbaid @Nicogene can we proceed in merging this PR?

@Nicogene
Copy link
Member

Nicogene commented Mar 9, 2023

I would say yes!

@mebbaid
Copy link
Contributor

mebbaid commented Mar 9, 2023

It's a go for me as well.

@traversaro traversaro merged commit c0fe4a0 into master Sep 15, 2023
@traversaro traversaro deleted the fix185 branch September 15, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nicogene Nicogene Nicogene approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Old configuration files - presumably not used
3 participants
@traversaro @mebbaid @Nicogene