Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iCubGazeboV2_* has r_wrist_yaw inverted #156

Closed
Nicogene opened this issue May 18, 2022 · 5 comments · Fixed by robotology/icub-models-generator#220
Closed

iCubGazeboV2_* has r_wrist_yaw inverted #156

Nicogene opened this issue May 18, 2022 · 5 comments · Fixed by robotology/icub-models-generator#220
Assignees
Labels

Comments

@Nicogene
Copy link
Member

As you can see from these videos, the rotation of r_wrist_yaw is the opposite w.r.t l_wrist_yaw:

wrists-yaw-icub2-2022-05-18_02.53.53.mp4

On the other hand, on iCubGazeboV3, iCubGazeboV2_5_visuomanip and on the real robot left and right are moving accordingly:

iCubGazeboV3:

wrists-yaw-icub3-2022-05-18_02.43.47.mp4

iCubGazeboV2_5_visuomanip:

wrists-yaw-icub2visuomanip.mp4
@Nicogene Nicogene added the bug label May 18, 2022
@traversaro
Copy link
Member

Thanks @Nicogene . I think this is an issue similar to #70 , but for iCubV2 . Whenever the Simmechanics model is regenerated from the Creo model, the actual direction of the exported axis is non-deterministic (from what we are able to understand in this years), and so the axis direction should be carefully checked and in case it is necessary we should update the reverseRotationAxis (https://github.com/robotology/icub-models-generator/blob/872c9bddaa33d1d3010ef1e63eb98760ebd9696d/simmechanics/CMakeLists.txt#L191). Apparently this went unnoticed, even because the tests for iCubV2 only involve the torso axis (see https://github.com/robotology/icub-models-generator/blob/0b244da996b1f0f308e6596d7e156c176e79c918/tests/icub-model-test.cpp#L227).

By looking a bit at the history of generation, the last generation of the iCubV2 model was back in robotology/icub-models-generator#122, so probably this bug was there in the last ~2.5 years, i.e. since icub-models 1.13.0 https://github.com/robotology/icub-models/releases/tag/v1.13.0 .

@traversaro
Copy link
Member

Mentioning @robotology/iit-artificial-mechanical-intelligence as it can be of interested to anyone working with iCub**V2** models: on those models the r_wrist_yaw joint has the wrong direction of motion since 2019.

@traversaro
Copy link
Member

The fix should be just to update the reverseRotationAxis option, volunteers to work on this are welcome. It would be great to also update the tests to detect regression of this kind, to avoid problems like that in the future.

@Nicogene Nicogene self-assigned this May 31, 2022
@Nicogene
Copy link
Member Author

Nicogene commented May 31, 2022

I can take this issue and work on it on spare time since it should not be complicated 👍🏻

(Maybe also @marcello-goccia)

@traversaro
Copy link
Member

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants