Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iCubGazeboV2_*: fix r_wrist_yaw direction #220

Merged
merged 1 commit into from
Jun 1, 2022
Merged

Conversation

Nicogene
Copy link
Member

@Nicogene Nicogene commented Jun 1, 2022

It fixes robotology/icub-models#156

Alongside @marcello-goccia, we fixed the r_wrist_yaw direction and we added a test for that.

Please review code

INCREASE_INERTIA_FOR_GAZEBO
ICUB_PLUS
ICUB_2_6
ICUB_2_7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick for future PRs: removing trailing whitespace is great, but try to keep it in a different dedicated commit, otherwise it will complicate reading the history in the future.

@traversaro
Copy link
Member

Did you run the tests? I had the impression that the direction of the wrist axis is not aligned with the y of the root_link due to the slight tilt of the shoulders, so I was surprise to see that the direction is instead aligned along the y of the root_link .

@traversaro
Copy link
Member

For some reason, CI is not running.

@traversaro traversaro closed this Jun 1, 2022
@traversaro traversaro reopened this Jun 1, 2022
@traversaro
Copy link
Member

For some reason, CI is not running.

Closing&opening the PR solved the problem.

@Nicogene
Copy link
Member Author

Nicogene commented Jun 1, 2022

Did you run the tests? I had the impression that the direction of the wrist axis is not aligned with the y of the root_link due to the slight tilt of the shoulders, so I was surprise to see that the direction is instead aligned along the y of the root_link .

Yes we got those numbers running the test ad it was surprising also for me, without the change on the reverseRotationAxis that test fail.

@Nicogene
Copy link
Member Author

Nicogene commented Jun 1, 2022

For some reason, CI is not running.

For inactivity the Workflow was disabled when we made the PR, I reenabled it but it didn't make it run

@traversaro
Copy link
Member

Thanks @Nicogene @marcello-goccia !

@traversaro traversaro merged commit fb615ed into master Jun 1, 2022
@traversaro traversaro deleted the fix/iCub25wristyaw branch June 1, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iCubGazeboV2_* has r_wrist_yaw inverted
3 participants