-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iCubGazeboV2_*: fix r_wrist_yaw direction #220
Conversation
INCREASE_INERTIA_FOR_GAZEBO | ||
ICUB_PLUS | ||
ICUB_2_6 | ||
ICUB_2_7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick for future PRs: removing trailing whitespace is great, but try to keep it in a different dedicated commit, otherwise it will complicate reading the history in the future.
Did you run the tests? I had the impression that the direction of the wrist axis is not aligned with the y of the root_link due to the slight tilt of the shoulders, so I was surprise to see that the direction is instead aligned along the y of the root_link . |
For some reason, CI is not running. |
Closing&opening the PR solved the problem. |
Yes we got those numbers running the test ad it was surprising also for me, without the change on the reverseRotationAxis that test fail. |
For inactivity the Workflow was disabled when we made the PR, I reenabled it but it didn't make it run |
Thanks @Nicogene @marcello-goccia ! |
It fixes robotology/icub-models#156
Alongside @marcello-goccia, we fixed the
r_wrist_yaw
direction and we added a test for that.Please review code