Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SDL for irrlicht visualizer on MacOS #1077

Merged
merged 3 commits into from
May 24, 2023
Merged

Use SDL for irrlicht visualizer on MacOS #1077

merged 3 commits into from
May 24, 2023

Conversation

lrapetti
Copy link
Member

Fix #1076

@lrapetti
Copy link
Member Author

@traversaro I don't know if this change should be referred to as FIX rather than CHANGED in the changelog, since the visualizer is not working at all on MacOS in the 9.0.0 release.

@traversaro
Copy link
Member

@traversaro I don't know if this change should be referred to as FIX rather than CHANGED in the changelog, since the visualizer is not working at all on MacOS in the 9.0.0 release.

Yes, I think it make, sense, let me re-word also the sentence.

@traversaro
Copy link
Member

@traversaro I don't know if this change should be referred to as FIX rather than CHANGED in the changelog, since the visualizer is not working at all on MacOS in the 9.0.0 release.

Yes, I think it make, sense, let me re-word also the sentence.

Let me know if the new sentence is ok.

@lrapetti
Copy link
Member Author

@traversaro I don't know if this change should be referred to as FIX rather than CHANGED in the changelog, since the visualizer is not working at all on MacOS in the 9.0.0 release.

Yes, I think it make, sense, let me re-word also the sentence.

Let me know if the new sentence is ok.

Looks good thanks @traversaro! I think we can merge it.

Maybe a release with the fix could make sense.

@traversaro
Copy link
Member

Ok!

@traversaro traversaro merged commit 8f2f6d6 into robotology:master May 24, 2023
@traversaro
Copy link
Member

Maybe a release with the fix could make sense.

Done: https://github.com/robotology/idyntree/releases/tag/v9.1.0 .

@lrapetti lrapetti deleted the fix-visualizer-macos branch May 25, 2023 10:28
@lrapetti lrapetti mentioned this pull request Sep 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@S-Dafarra S-Dafarra S-Dafarra approved these changes

@traversaro traversaro traversaro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Irrlicht Visualizer not working in MacOS
3 participants
@lrapetti @traversaro @S-Dafarra