Remove IDYNTREE_USES_KDL option #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traversaro
force-pushed
the
remove_deprecated_kdl
branch
from
a7c8d23
to
d8128e2
Compare
|
PR ready to review. |
S-Dafarra
approved these changes
Jun 12, 2020
diegoferigo
approved these changes
Jun 12, 2020
All the code that was enabled by the IDYNTREE_USES_KDL option was deprecated in iDynTree 1.0 .
traversaro
force-pushed
the
remove_deprecated_kdl
branch
from
d8128e2
to
e3c9d7e
Compare
traversaro
force-pushed
the
remove_deprecated_kdl
branch
from
e3c9d7e
to
87788eb
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the code that was enabled by the IDYNTREE_USES_KDL option was deprecated in iDynTree 1.0 .
Furthermore, bump the CMake version to 1.99 as the code currently in
develwill remove some deprecated features, and so it will be released under the new major version as iDynTree 2.The CI will probably fail as I still need to regenerate the MATLAB bindings.
This classes are still used by the DH-based generate pipeline in https://github.com/robotology/icub-model-generator, but that code can continue to use iDynTree 1.x until is migrated.