-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove semantics check classes and related methods #704
Conversation
These classes were deprecated in iDynTree 1.0, see #622 for more details.
997237b
to
2aac356
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a huge work, thanks @traversaro. I agree that this was somehow needed. We never managed to exploit this code that much. Personally, even after few years spent around iDynTree's code, I am still struggling to connect the dots in the middle of the semantic sections.
I agree that this simplifies a potential support of AD, and currently is perhaps a better aim that could become really useful to many.
What I didn't get exactly from this PR is all the class names changes. Can you please super briefly recap these modification? It could be useful as implicit documentation.
- I see a concrete
GeomVector3
. How does it differ from*Vector*
? - It is not very clear to me why the
set|getMeasurement
have been removed. I'm not familiar with that code and I could be missing a step.
Basically, all the semantics aware such as
It is basically a change due to the fact that now |
Great! Thanks for the explanation, now it's clear :) |
These classes were deprecated in iDynTree 1.0, see #622 for more details.
Sorry for the huge PR, but as all the different classes were related to one another, it was difficult to split the PR in smaller chunks.
The relevant commit is d293786, while 997237b is the commit full of autogenerated MATLAB bindings files.
As the modification are quite extensive, I am afraid reviewers will need to trust a bit me on this. However, a quick general sanity check would be useful.