Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove functionalities deprecated in iDynTree 1 #751

Merged
merged 4 commits into from
Oct 27, 2020
Merged

Remove functionalities deprecated in iDynTree 1 #751

merged 4 commits into from
Oct 27, 2020

Conversation

traversaro
Copy link
Member

Fix #742 .

@S-Dafarra
Copy link
Contributor

I have tried compiling it in my machine, but it failed because of the bindings. I guess those need to be changed as well right?

@traversaro
Copy link
Member Author

I have tried compiling it in my machine, but it failed because of the bindings. I guess those need to be changed as well right?

Yes, sorry I was a bit to optimistic assigning reviewers before checking the CI. I still need to work to fix the CI.

@traversaro
Copy link
Member Author

I have tried compiling it in my machine, but it failed because of the bindings. I guess those need to be changed as well right?

Yes, sorry I was a bit to optimistic assigning reviewers before checking the CI. I still need to work to fix the CI.

The ExtWrenchesAndJointTorquesEstimator::loadModelAndSensorsFromFile is still used in a lot of repos, there is no specific reason to drop it.

@traversaro
Copy link
Member Author

The PR is now ready for review. @S-Dafarra @lrapetti It is quite massive and just removals and cleanup code that was using deprecate functions, so feel free to just give a glance to it.

@S-Dafarra S-Dafarra mentioned this pull request Oct 27, 2020
Closed
@traversaro traversaro merged commit bea7ae0 into devel Oct 27, 2020
@traversaro traversaro deleted the remove-deprecations branch October 27, 2020 14:11
@traversaro traversaro mentioned this pull request Oct 27, 2020
Closed
@S-Dafarra S-Dafarra mentioned this pull request Oct 28, 2020
Merged
@diegoferigo diegoferigo mentioned this pull request Nov 9, 2020
Merged
@S-Dafarra S-Dafarra mentioned this pull request Nov 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@S-Dafarra S-Dafarra S-Dafarra approved these changes

@lrapetti lrapetti Awaiting requested review from lrapetti

@diegoferigo diegoferigo Awaiting requested review from diegoferigo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@traversaro @S-Dafarra