Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore the linking of iDynTreeMEX target on MATLAB libraries #789

Merged
merged 2 commits into from
Dec 3, 2020
Merged

Restore the linking of iDynTreeMEX target on MATLAB libraries #789

merged 2 commits into from
Dec 3, 2020

Conversation

traversaro
Copy link
Member

Fix #788 .

This was a regression from #746, in particular from here https://github.com/robotology/idyntree/pull/746/files#diff-9d10f303173345085f88ea98e48217c2a1facafafbdeb9d41cd94060ed45d5b7L95 in which the line:

swig_link_libraries(${mexname} ${Matlab_LIBRARIES} ${IDYNTREE_LIBRARIES} idyntree-core)

was removed, but only:

target_link_libraries(${target_name} ${IDYNTREE_LIBRARIES} idyntree-core)

was added back.

@traversaro traversaro requested a review from lrapetti December 3, 2020 16:38
lrapetti
lrapetti approved these changes Dec 3, 2020
View reviewed changes
Copy link
Member

@lrapetti lrapetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have also tested this branch and it is working fine on my laptop

@traversaro
Copy link
Member Author

LGTM, I have also tested this branch and it is working fine on my laptop

You also tested the bindings or you just tested compilation?

@traversaro traversaro merged commit be3f0dc into master Dec 3, 2020
@traversaro traversaro deleted the fix/788 branch December 3, 2020 18:21
@lrapetti
Copy link
Member

lrapetti commented Dec 3, 2020

LGTM, I have also tested this branch and it is working fine on my laptop

You also tested the bindings or you just tested compilation?

I just tested also the bindings and work fine

@traversaro traversaro mentioned this pull request Jan 13, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrapetti lrapetti lrapetti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing to compile when MATLAB is ON on MacOS
2 participants
@traversaro @lrapetti