YARP: Enable compilation of bottle_compression_zlib, depthimage_compression_zlib and image_compression_ffmpeg portmonitors #1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ession_zlib and image_compression_ffmpeg portmonitors
|
CI is happy, we can address any comment in future PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enable in YARP the CMake options to ensure that the following portmonitor are enabled:
bottle_compression_zlibdepthimage_compression_zlibimage_compression_ffmpegThese portmonitors are already used by the HSP team working on ergocub (fyi @andrearosasco) and can be useful for anyone sending big amount of data over a YARP network (@S-Dafarra @GiulioRomualdi @mebbaid @davidegorbani).
This PR also adds the required dependencis (ffmpeg and zlib) to the dependency of the superbuild. This was already discussed in #1071, but we decided not to proceed as some devices in YARP (
ffmpeg_grabberandffmpeg_writer) were not compatible with ffmpeg 5. However, it turns out thatimage_compression_ffmpegcan be used and can be useful on its own, so I think it make sense to proceed with this change, even because it would permit some HSP/ergoCub demo to run with a stock superbuild.The corresponding PR in the yarp-feedstock recipe is: conda-forge/yarp-feedstock#31 .