Fix MATLAB and Octave snippets #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 11, 2021
|
Hi @giovannipizzolante , can you review this PR? See https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/about-pull-request-reviews for how to do that, thanks! |
|
Just came back from a mission, I’ll review asap! |
Thanks, take your time, this is not urgent! |
|
Please ignore the failing CI, that is unrelated (see #733). |
lnobile
approved these changes
May 17, 2021
Thanks! Just FYI, if you want to have a simple way to install YARP MATLAB bindings on any system in which MATLAB runs, you can check the new one-line MATLAB installer: https://github.com/robotology/robotology-superbuild/blob/master/doc/matlab-one-line-install.md . |
|
Other CI failures are unrelated, see #733 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For YARP Vectors, the
fromMatlabmethods expects the YARP vector to be of the same size of the passed MATLAB vector, see #515 and robotology/yarp-matlab-bindings#62 .