Disable ROBOTOLOGY_USES_MATLAB in vcpkg/Windows CI #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I launched a job on my fork to verify if this fixes #774 : https://github.com/traversaro/robotology-superbuild/runs/2713367057?check_suite_focus=true . If that works, I will upload the resulting installer manually in https://github.com/robotology/robotology-superbuild/releases/tag/v2021.05, and cherry-pick this modification in the |
Nicogene
approved these changes
Jun 1, 2021
traversaro
added a commit
that referenced
this pull request
Jun 1, 2021
Nicogene
pushed a commit
to Nicogene/robotology-superbuild
that referenced
this pull request
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MATLAB is already tested on Conda/Windows and distributed as Conda binaries (including in convenient form such as the one-line installer: https://github.com/traversaro/robotology-superbuild.git). There was a recent regression in the vcpkg-based installer due to MATLAB, the easier choice is just to disable MATLAB in the vcpkg-installer, and just support it on Conda/Windows .