Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BuildYARP: Enable all fake** devices #797

Merged
merged 2 commits into from
Jun 14, 2021
Merged

BuildYARP: Enable all fake** devices #797

merged 2 commits into from
Jun 14, 2021

Conversation

traversaro
Copy link
Member

@traversaro traversaro commented Jun 14, 2021

All the fake*** devices are quite useful for tutorials and tests and they do not have strange deps, so let's enable them.

Let's check CI with attention as it is possible that some of this devices have compilation problems in some platforms tested by CI.

@traversaro traversaro requested a review from pattacini June 14, 2021 15:56
@pattacini
Copy link
Member

I think this won't be backported to 2021.05.
However, I wouldn't expect any problem for the time being given that the training on YARP has been already done today.

This comment is just in view of merging vvv-school/tutorial_yarp-basics#2.

@traversaro
Copy link
Member Author

I think this won't be backported to 2021.05.

We can backport to 2021.05 if you like, but we would need a new tag in any case to properly propagate it to robot-bazaar, etc etc.

@pattacini
Copy link
Member

We can backport to 2021.05 if you like, but we would need a new tag in any case to properly propagate it to robot-bazaar, etc etc.

I think we're fine anyway 👍🏻

@traversaro traversaro merged commit 9ccca27 into master Jun 14, 2021
@traversaro traversaro deleted the yarp-enable-fake branch June 14, 2021 20:33
Nicogene pushed a commit to Nicogene/robotology-superbuild that referenced this pull request Feb 14, 2022
* BuildYARP: Enable all fake** devices
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants