Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to 0.3.0, fix Windows compilation and change license to BSD-3-Clause #46

Merged
merged 3 commits into from
Oct 17, 2023

Conversation

traversaro
Copy link
Member

@traversaro traversaro commented Oct 17, 2023

Fix #45 .
Fix #44 .

For some reason the CI is super-slow, but that is another story.

@traversaro traversaro changed the title Bump to 0.3.0 and change license to BSD-3-Clause Bump to 0.3.0, fix Windows compilation and change license to BSD-3-Clause Oct 17, 2023
@traversaro
Copy link
Member Author

For some reason the CI is super-slow, but that is another story.

Actually, I also fixed this in 9062fc3, I could not wait for the CI to be happy.

@traversaro
Copy link
Member Author

For some reason the CI is super-slow, but that is another story.

Actually, I also fixed this in 9062fc3, I could not wait for the CI to be happy.

Cool, Linux CI time decreased from 23 minutes to 2 minutes, Windows from >= 60 minutes to 5 minutes.

@traversaro
Copy link
Member Author

@HosameldinMohamed the PR is ready for review.

Copy link
Contributor

@HosameldinMohamed HosameldinMohamed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

# Authors: Silvio Traversaro <silvio.traversaro@iit.it>
# CopyPolicy: Released under the terms of the LGPLv2.1 or later, see LICENSE
# SPDX-FileCopyrightText: Fondazione Istituto Italiano di Tecnologia (IIT)
# SPDX-License-Identifier: BSD-3-Clause

cmake_minimum_required(VERSION 3.5)
project(yarp-device-xsensmt)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding setting the project version in the CMake file, I see it's done for many other projects, but here it's not set.

I'm not sure if it's needed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not installing any CMake version file for the project, so there is no benefit in keeping the version in the CMake project.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@traversaro traversaro merged commit bd3a047 into master Oct 17, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a new release out of the current state [windows-2019@Release@conda] CI failure
2 participants