-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to 0.3.0, fix Windows compilation and change license to BSD-3-Clause #46
Conversation
Actually, I also fixed this in 9062fc3, I could not wait for the CI to be happy. |
Cool, Linux CI time decreased from 23 minutes to 2 minutes, Windows from >= 60 minutes to 5 minutes. |
@HosameldinMohamed the PR is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
# Authors: Silvio Traversaro <silvio.traversaro@iit.it> | ||
# CopyPolicy: Released under the terms of the LGPLv2.1 or later, see LICENSE | ||
# SPDX-FileCopyrightText: Fondazione Istituto Italiano di Tecnologia (IIT) | ||
# SPDX-License-Identifier: BSD-3-Clause | ||
|
||
cmake_minimum_required(VERSION 3.5) | ||
project(yarp-device-xsensmt) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding setting the project version in the CMake file, I see it's done for many other projects, but here it's not set.
I'm not sure if it's needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are not installing any CMake version file for the project, so there is no benefit in keeping the version in the CMake project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense!
Fix #45 .
Fix #44 .
For some reason the CI is super-slow, but that is another story.