Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Yarp.js to node.js 14.19.1 #46

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nunoguedelha
Copy link
Collaborator

@nunoguedelha nunoguedelha commented May 6, 2022

Fixes #45 .

Updated package-lock.json.

Tested https://github.com/robotology/yarp.js/blob/master/examples/examples.js, more precisely the video streaming example with the scrolling line from fakeFrameGrabber:

  • on Firefox --> PASS
  • on Chrome --> the video stream is stuttering. => shall be investigated later after we test the yarp-openmct upgrade.

- Update package-lock.json
@nunoguedelha nunoguedelha self-assigned this May 6, 2022
@nunoguedelha nunoguedelha requested a review from traversaro May 6, 2022 11:17
@traversaro
Copy link
Member

@nunoguedelha is this still draft?

@nunoguedelha
Copy link
Collaborator Author

Sorry @traversaro , saw this now. Yes it is still draft since I haven't had time to work on the analysis of the regressions. I'm focusing 100% on the plot issues, which has a major impact on the user experience, as we agreed.

I'm hopping to be done with the plot issues in a week or so, then I'll resume the work on this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Node.js 14.19.1
2 participants