Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

Required subscription validation #374

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Spexxel
Copy link
Contributor

@Spexxel Spexxel commented Mar 20, 2022

There are several new issues about failing to start a stream where some of them the issue was not having an active F1TV subscription. #333 and #363
In order to add to the user-experience I have made a simple validation and errormessage for this case.

Functionality changes:
When users try to watch content without a valid F1TV subscription an user-friendly error will be shown along with the minimum subscription level needed for that content (Access/Pro).
image

Code Changes:

  • Added the minimum subscriptionlevel needed for F1TV resources to the IPlayableContent and its implementations. This field comes from the F1TV api response field 'Entitlement'.
  • Added a simple validation on SubscriptionStatus at the start of the watch and download-actions.

Sadly we do not know the type of subscription the user has since F1TV does not return that upon authorizing.(Maybe there is a different way, but didnt check as I went for a simple validation)

@Spexxel Spexxel changed the title Required subscription Required subscription validation Mar 21, 2022
@crescog
Copy link

crescog commented Apr 8, 2022

From today race control does not recognize my access credentials. the message says: request failed except status code forbideen.
What I can do.
my email is: crisesco50@hotmail.com

@imnotnoa
Copy link

imnotnoa commented Apr 8, 2022

From today race control does not recognize my access credentials. the message says: request failed except status code forbideen. What I can do. my email is: crisesco50@hotmail.com

This is already being addressed: #414

Also, pull request comment threads are not the way to submit issues.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants