Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File api #387

Closed
wants to merge 10 commits into from
Closed

File api #387

wants to merge 10 commits into from

Conversation

TwitchBronBron
Copy link
Member

@TwitchBronBron TwitchBronBron commented Apr 20, 2021

Moves file handling into plugin-land so plugins can contribute custom file types. This PR depends on #330 .

Notable changes:

  • added plugin event onProvideFile. If a plugin returns a file, that file is used. Otherwise, move on to next plugin until we run out. The program will handle all non-plugin-handled files.
  • every single file found in the files array that actually exists on disk will be included in the program. (this will help support the custom tree view we wanted to add in vscode but couldn't because non xml and brs files were missing)
  • make almost all BscFile functions and properties optional so plugin-contributed files only need to write what they need.
  • adds several file contribution points for both xml and brs file types, so any file could theoretically contribute all of that information (work-in-progress)

@TwitchBronBron TwitchBronBron mentioned this pull request May 7, 2021
@TwitchBronBron
Copy link
Member Author

Closed in favor of #408

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant