-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File api #408
Merged
Merged
File api #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Deprecate `pathAbsolute`
TwitchBronBron
force-pushed
the
file-api
branch
from
September 20, 2022 16:53
b78f0b8
to
6adcd56
Compare
Rename `BscFile` to `File`
Support overriding file contents during provide events. Deprecate the file parse events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves file handling into plugin-land so plugins can contribute custom file types. (Migrated from #387 )
Notable changes:
onProvideFile
(andbeforeProvideFile
/afterProvideFile
events too). Plugins can add files to the.files
array of the event.files
array that exist on disk will be included in the program. Files not handled by plugins and bsc will be loaded asAssetFile
instances, and are copied as-is. (this will help support the custom tree view we wanted to add in vscode but couldn't because non xml and brs files were missing)File
that desribes the important parts of a file. This makes most file properties optional, so plugin-contributed files only add what they actually implement.beforeFileRemove
andafterFileRemove
events, deprecatebeforeFileDispose
andafterFileDispose
events.beforeFileAdd
andafterFileAdd
events that are triggered after theprovide
events for every file that plugins create.