Remove proc evaluation in payload values. #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We needed it to evaluate the person data proc, that it's defined as part of the scope in the Rails middleware. Because it's defined before the person data is set by the controllers, we still need to use a proc for it. We evaluate the person data while we are building the payload but removing the evaluation of all defined proc in the configuration. We'll think in the future about the correct feature for the users, but this approach was a little dangerous.
brianr
added a commit
that referenced
this pull request
Oct 17, 2014
Remove proc evaluation in payload values.
|
Looks good - this feels much better. We can decide separately about the "evaluate procs in the payload" feature for a later release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requested by @brianr
We needed it to evaluate the person data proc, that it's defined as part of the scope in the Rails middleware. Because it's defined before the person data is set by the controllers, we still need to use a proc for it. We evaluate the person data while we are building the payload but removing the evaluation of all defined proc in the configuration.
We'll think in the future about the correct feature for the users, but this approach was a little dangerous.