Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove proc evaluation in payload values. #143

Merged
merged 1 commit into from
Oct 17, 2014
Merged

Remove proc evaluation in payload values. #143

merged 1 commit into from
Oct 17, 2014

Commits on Oct 17, 2014

  1. Remove proc evaluation in payload values. 

    We needed it to evaluate the person data proc, that it's defined as part of the scope in the Rails middleware. Because it's defined before the person data is set by the controllers, we still need to use a proc for it. We evaluate the person data while we are building the payload but removing the evaluation of all defined proc in the configuration.

We'll think in the future about the correct feature for the users, but this approach was a little dangerous.
    Jon de Andres committed Oct 17, 2014
    Configuration menu
    Copy the full SHA
    c5dbceb View commit details
    Browse the repository at this point in the history