Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error duplication for non generic exceptions #293

Closed
ftrrtf opened this issue Nov 28, 2017 · 1 comment
Closed

Error duplication for non generic exceptions #293

ftrrtf opened this issue Nov 28, 2017 · 1 comment
Assignees
Labels
Type: Bug Fix a component so that its behavior aligns with its documentation.

Comments

@ftrrtf
Copy link

ftrrtf commented Nov 28, 2017

@ArturMoczulski hi, I guess condition (from MR #240)
strpos($last_error['message'], 'Uncaught exception') === 0 should be replaced by strpos($last_error['message'], 'Uncaught') === 0 (allowed types of exception is checked on the line above).

Because for now only generic exceptions will be skipped by the condition on fatal handler, and MyException will be logged one more time.

We are experiencing such issue with each symfony/php7 app (have not tested with other environments), when even fatals are exceptions, plus wrapped by symfony stuff, like:
Uncaught Symfony\\Component\\Debug\\Exception\\FatalThrowableError: Call to a member function getId() on null in /var/www/...

@rivkahstandig3636 rivkahstandig3636 added the Type: Bug Fix a component so that its behavior aligns with its documentation. label Nov 29, 2017
ArturMoczulski added a commit that referenced this issue Dec 2, 2017
Github Issue #293: Error duplication for non generic exceptions
@ArturMoczulski
Copy link
Contributor

This is resolved in PR #295

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Fix a component so that its behavior aligns with its documentation.
Projects
None yet
Development

No branches or pull requests

3 participants