Github Issue #236: Error Duplication #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… already logged by the exceptionHandler
Closed
rokob
reviewed
Jul 31, 2017
src/Rollbar.php
Outdated
| in_array($last_error['type'], self::$fatalErrors, true) && | ||
| // don't log uncaught exceptions as they were handled by exceptionHandler() | ||
| isset($last_error['message']) && | ||
| strpos($last_error['message'], 'Uncaught exception') !== 0; |
There was a problem hiding this comment.
The !== 0 should be !== false because strpos can return 0 if that is the start of the string, but returns false exactly to indicate not found.
There was a problem hiding this comment.
Oh I see what you are doing, the logic is a bit off for having two ands because you want to log the fatal if message is not set also
There was a problem hiding this comment.
Yeah. @rokob thanks for keeping your eyes open though
Change condition for what defines an uncaught exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes uncaught exceptions being reported twice as per issue #236
Ready for review