Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@rollup/plugin-replace failing since 2.4.0 #812

Closed
diego-antonelli opened this issue Feb 22, 2021 · 3 comments · Fixed by #813
Closed

@rollup/plugin-replace failing since 2.4.0 #812

diego-antonelli opened this issue Feb 22, 2021 · 3 comments · Fixed by #813

Comments

@diego-antonelli
Copy link

Expected Behavior

Pass builds without throw error

Actual Behavior

Throwing the following error: Error: @rollup/plugin-replace: 'preventAssignment' currently defaults to false. It is recommended to set this option to true, as the next major version will default this option to true.

Even adding preventAssignment it throws the error and rollup aborts the builds.

Additional Information

It is happening since the last update 12h ago

@shellscape
Copy link
Collaborator

@diego-antonelli we closed your previous issue because you disregarded the information about requiring a valid reproduction. Creating a duplicate issue doesn't make the invalid reproduction any more valid. Please do not create further duplicates, and please do not create additional issues that disregard our templates.

Closing as duplicate of #811 and for lacking a valid reproduction.

@diego-antonelli
Copy link
Author

diego-antonelli commented Feb 22, 2021

@shellscape I added a link with a valid case at least was showing the error. Also @danielroe mentioned this issue in his PR, but now the issue is closed.

I was just trying to help reporting the problem that was already recognized by Daniel.

@shellscape
Copy link
Collaborator

Our issue templates thoroughly explain what options for valid reproductions are. What you feel is valid for triage is not necessarily what maintainers here need. Please respect their hard work and the time they give freely to make your work easier, by taking a few extra moments from your day to follow the guidelines in our issue templates.

shellscape pushed a commit that referenced this issue Feb 22, 2021
)

* fix(replace): add missing types for new `preventAssignment` option

closes #812

* chore: trigger ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants