Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(replace): add missing types for new preventAssignment option #813

Merged
merged 2 commits into from
Feb 22, 2021

Conversation

danielroe
Copy link
Contributor

@danielroe danielroe commented Feb 22, 2021

Rollup Plugin Name: @rollup/replace

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

🤦‍♂️ Failed to add types for change in previous PR (#798). Closes #812.

@diego-antonelli
Copy link

diego-antonelli commented Feb 22, 2021

@danielroe I am pretty sure my error is not related to typings, as I am not executing it in typescript.

@danielroe
Copy link
Contributor Author

danielroe commented Feb 22, 2021

@diego-antonelli Would you check - as I noticed your tests are written in TypeScript? (A type error would cause jest specs to fail, whereas the warning shouldn't cause rollup to abort the build - but I might be wrong!)

@diego-antonelli
Copy link

@diego-antonelli Would you check - as I noticed your tests are written in TypeScript? (A type error would cause jest specs to fail, whereas the warning shouldn't cause rollup to abort the build - but I might be wrong!)

I am doing a quick test, please wait 5 min to merge this PR, please

@diego-antonelli
Copy link

@danielroe indeed was just the typings. Funny thing is: Jest is simply dying without throw any error, but this is not related to your fix. Thanks a lot for the quick fix!!

danielroe added a commit to danielroe/siroc that referenced this pull request Feb 22, 2021
* fix type error in `@rollup/plugin-replace` pending rollup/plugins#813

closes #204
@shellscape
Copy link
Collaborator

Thanks for the PR. Looks like a few checks are failing there. Please have a look.

@danielroe
Copy link
Contributor Author

danielroe commented Feb 22, 2021

@shellscape The unit tests are all succeeding. Looks like it is a codecov failure. Note that the failing tests are also failing on master branch.

@shellscape
Copy link
Collaborator

okay thanks for taking a look. I'll see what I can do about that in a few hours today

@shellscape
Copy link
Collaborator

Looks like codecov is having some issues today. We'll bypass. Thanks for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@rollup/plugin-replace failing since 2.4.0
3 participants