[WIP] Progress towards 2.0 support and tslib

[PaulBGD]

Issues this PR will attempt to solve:

• TypeScript Helpers aren't processed by later plugins #87
• Missing support for the __generator helper #85
• Add support for object __rest helper when using custom typescript 2.1 #81
• Improve error headling #67
• Specify tsconfig.json file #66
• Plugin doesn't output non-fatal errors. #43

There are some other issues that I'm looking at adding with this larger PR, but for now those issues outline my goals.

[LukeSheard]

I've just started to use this and noticed the lack of TS2 support. What else needs doing to do this?

[PaulBGD]

@LukeSheard With this PR TS2 support is included and works. Mostly working on other issues now.

[LukeSheard]

@PaulBGD Lemme know if you want a hand. Would be happy to contribute.

[PaulBGD]

@LukeSheard Would love some more tests of the tslib helpers and I need to figure out a way to test that the library supports both 1.0 and 2.0.

The biggest thing I think is integrating #84, but I'm waiting on a response from @kryops on that.

[LukeSheard]

@PaulBGD I've just tried out https://github.com/ezolenko/rollup-plugin-typescript2 as well and it's pretty slick. We could probably take a lot of ideas from that.

[ezolenko]

Main difference of this plugin (after ongoing updates) and mine is error checking -- all the caching and other stuff is mainly for solving problems introduced by error checking. I'm also probably committing a few grave sins as far as using plugin API goes.

Feel free to take as much or as little as makes sense. :) Once official plugin starts supporting error checking (#43), I'll depreciate mine (unless it is faster :)).

[PaulBGD]

The only thing left before I'm ready to publish this, is that we need way more tests. All the issues I listed seem to be complete with the changes in this branch.

EDIT: also will be looking at performance, to see if there's anything we can do to improve that.

[matthew-dean]

Btw, typescript should be listed in package.json as a peer dependency, not a dependency IMO. That would better address issues with typescript version and remove the need to explicitly pass in TypeScript.

[PaulBGD]

@matthew-dean The issue is, we want to provide a single install way for people to get started with Rollup and TypeScript. While I agree that a lot of people that use this plugin will just install their own TypeScript version, I think including this single package will make this easier for newer users.

[goumang2010]

Is there any progress?

[PaulBGD]

@goumang2010 I'm currently trying to find the best way to support definition files, this seems to fulfill the same behavior as tsc but feels like a hack: https://github.com/rollup/rollup-plugin-typescript/pull/91/files#diff-1fdf421c05c1140f6d71444ea2b27638R92

[YowaiCoder]

waiting for this, I'm not considering non-official plugins or gulp-ts or whatever.

[PaulBGD]

@fightingcat Something you could help with, check if this PR just works. Ideally it should work the same or better with the current master + typescript 2.

[StreetStrider]

@PaulBGD this PR is intended to introduce tslib? Is it correct that tslib is a natural replacement for now present «synthetic» typescript-helpers?

[PaulBGD]

@StreetStrider Yes.

[Rich-Harris]

I've just updated this branch so that it's mergeable, but none of the tests will pass — it's giving me this error...

Cannot find type definition file for 'react'.

...even for tests that have nothing to do with React. Any idea what's going on?

[StreetStrider]

@Rich-Harris, just checked this, I'm seeing the same thing. @types/react is present on my side (I believe, you have one too). That strange, because when I use this plugin it does not fail on any typecheck errors. I use tsc for typecheck (--noEmit) and Rollup + plugin for bundling/transpiling. Rollup and plugin do all the work even if any typecheck errors is present. So this error presumably have another nature.
@PaulBGD

[PaulBGD]

@Rich-Harris Yeah I updated it locally and ran into the same issue, the main thing I can figure out is that we're discovering .ts files wrong (or not letting typescript handle discovery..)

[niklashigi]

I'm currently trying to find the best way to support definition files

@PaulBGD Any updates on this? Being able to generate .d.ts files for Rollup bundles would be incredibly useful.

[PaulBGD]

Sorry when I took this on I thought I had more time to work on it. I can try to spend some more time on it, but I'm definitely looking towards merging one of the better working forks back upstream.

[grahammendick]

There's a workaround for the tslib issues

1. Install tslib and rollup-plugin-node-resolve, npm install tslib rollup-plugin-node-resolve
2. Tell the typescript plugin to import tslib, set importHelpers to true.
3. Use the node resolve plugin to generate the helper code from the tslib package

plugins: [
    rollupTypescript({
        importHelpers: true,
    }),
    nodeResolve({ jsnext: true, main: true })
]

[shellscape]

@PaulBGD we're getting ready to move this plugin to a new home at https://github.com/rollup/plugins, and unfortunately we don't have time as a small team to review all pending PRs before we do that. We're closing any pending feature PRs, but please do not delete your branch. We'd love for you to open a new PR for review at the new repo once that move is done. There shouldn't be too many changes, just a new file structure, so it should be relatively painless.