Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Client can change color of rectangle for difference / excluded part. #205

Closed
woosyume opened this issue Mar 25, 2021 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@woosyume
Copy link
Contributor

Is your feature request related to a problem? Please describe.

What

As a new feature, I'm suggesting that client can set color for rectangles with the difference.

Background

About my case,
When we release something, we run image comparison for before and after deployment.
It's job of internal automation app based on Selenium WebDriver.

But we sometime take time to find diff rectangle when it's exists because there are some other parts with red colored.
Maybe you can see it with the following page.
https://www.rakuten.co.jp/

That's why I want to set other color so that we can find difference as soon as possible.

Detail

Describe the solution you'd like
Add a public method to ImageComparison.java to set color.
Sample

    public Color setDiffRectangleColor(Color color) {
        this.color = color;
        return this;
    }
...
        graphics.setColor(this.color);

Describe alternatives you've considered
Nothing special.

Additional context
Nothing special.

@woosyume woosyume added the enhancement New feature or request label Mar 25, 2021
@woosyume woosyume changed the title [FEATURE] [FEATURE] Client can change color of rectangle for difference / excluded part. Mar 25, 2021
@woosyume
Copy link
Contributor Author

Currently I'm working with this but don't have permission to push to working branch remotely.
Could you grant me?
@romankh3

@romankh3
Copy link
Owner

Hello @woosyume.
Thanks for your contributions.
In GitHub we're using The forking workflow branching strategy to contribute to another repository.
In a nutshell, you need to fork image-comparison, make updates in the development branch and create pull-request to development branch in original image-comparison project.

woosyume pushed a commit to woosyume/image-comparison that referenced this issue Mar 25, 2021
woosyume pushed a commit to woosyume/image-comparison that referenced this issue Mar 25, 2021
@woosyume
Copy link
Contributor Author

I've created a pull request following the above rule.
Please kindly check it.
Regards,
Kim

romankh3 pushed a commit that referenced this issue Mar 28, 2021
#205: added ability to set rectangle color.
Co-authored-by: Aaron Kim <woohyeok.kim@rakuten.com>
@romankh3
Copy link
Owner

merged to the development branch.

@romankh3 romankh3 mentioned this issue Mar 28, 2021
10 tasks
romankh3 added a commit that referenced this issue Mar 28, 2021
4.4.0: added #205 ability to change rectangle color.

Co-authored-by: Aaron's Sandbox <woosyume@gmail.com>
@romankh3
Copy link
Owner

@woosyume thanks for your contribution to the image-comparison project.
Your updated added to the 4.4.0 version and can be retrieved.

thanks,
Roman.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants