[#205] Set Rectangle Color (Diff / Exclude) #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romankh3
reviewed
Mar 25, 2021
| @@ -464,7 +465,9 @@ public void shouldProperlyWorkGettersAndSetters() { | |||
| .setThreshold(400) | |||
| .setDifferenceRectangleFilling(true, 35.1) | |||
| .setExcludedRectangleFilling(true, 45.1) | |||
| .setAllowingPercentOfDifferentPixels(48.15); | |||
| .setAllowingPercentOfDifferentPixels(48.15) | |||
| .setDifferenceRectangleColor(Color.RED) | |||
There was a problem hiding this comment.
It's good to set a non-default value here. The same for line 469.
Please, update it.
There was a problem hiding this comment.
Thank you for your comment.
Could you please let me know that you mean only set a non-default value for test class or for main modification as well?
There was a problem hiding this comment.
Only for test case to be ensure, that setter works as well as we expected.
Default values for production code should be the same as were before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Description
As a new feature, I'm suggesting that client can set color for rectangles with the difference.
Related Issue
#205
Motivation and Context
About my case,
When we release something, we run image comparison for before and after deployment.
It's job of internal automation app based on Selenium WebDriver.
But we sometime take time to find diff rectangle when it's exists because there are some other parts with red colored.
Maybe you can see it with the following page.
https://www.rakuten.co.jp/
That's why I want to set other color so that we can find difference as soon as possible.
How Has This Been Tested
Tested in UT level
Types of changes
Checklist