#167 added option to fill rectangles #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romankh3
requested changes
Jan 19, 2020
| * @param rectangles rectangles the collection of the {@link Rectangle}. | ||
| * @param percentOpacity the opacity of the fill. | ||
| */ | ||
| private void fill(Graphics2D graphics, List<Rectangle> rectangles, double percentOpacity) { |
There was a problem hiding this comment.
Let's make the method name more self-describing.
There was a problem hiding this comment.
I renamed it from fill to fillRectangles
|
@MrMisterG thanks for your contributions! |
romankh3
added a commit
that referenced
this pull request
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
See issue #167 for details
Description
See issue #167
Related Issue
#167
Motivation and Context
See issue #167
How Has This Been Tested
Added two new tests that follow a similar style as existing tests
Types of changes
Checklist