#167 added option to fill rectangles (#168) #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrMisterG
reviewed
Jan 20, 2020
| @@ -63,12 +67,12 @@ Can be found in [RELEASE_NOTES](RELEASE_NOTES.md). | |||
| <dependency> | |||
| <groupId>com.github.romankh3</groupId> | |||
| <artifactId>image-comparison</artifactId> | |||
| <version>4.0.0</version> | |||
| <version>4.0.1</version> | |||
There was a problem hiding this comment.
Do you also need to update the version here?
MrMisterG
reviewed
Jan 20, 2020
| </dependency> | ||
| ``` | ||
| #### Gradle | ||
| ```groovy | ||
| compile 'com.github.romankh3:image-comparison:4.0.0' | ||
| compile 'com.github.romankh3:image-comparison:4.0.1' |
There was a problem hiding this comment.
Do you also need to update the version here?
There was a problem hiding this comment.
Of course, I'll do it. Thanks for your catch.
MrMisterG
suggested changes
Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prepared for new development process.
Update README.md
[IMPROVEMENT] fill excluded rectangles with transparent green #167: Added options to draw transparent fill inside rectangles
[IMPROVEMENT] fill excluded rectangles with transparent green #167: Code review fix: Renamed method name
Co-authored-by: Roman Beskrovnyi roman.beskrovnyy@gmail.com
PR Details
Description
Related Issue
Motivation and Context
How Has This Been Tested
Types of changes
Checklist