Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLI] Add a suffix to multisign psrt file #2589

Closed
jolestar opened this issue Sep 6, 2024 · 1 comment · Fixed by #2641
Closed

[CLI] Add a suffix to multisign psrt file #2589

jolestar opened this issue Sep 6, 2024 · 1 comment · Fixed by #2641
Assignees
@feliciss
Labels
area::cli CLI relative issues proposal New external API or other notable changes skill::rust Need the rust language skill to complete the issue
Milestone
Rooch v0.8

Comments

@jolestar
Copy link
Contributor

jolestar commented Sep 6, 2024

Proposal Details

When using rooch tx sign to sign a multisign tx, the command will generate a psrt file.

We can add a suffix to the file to distinguish how many participants have signed the tx.

[tx_hash_prefix].[signature_cout].psrt,

eg: e93f585e5a24a667-1.psrt is the first signature of e93f585e5a24a667.
@jolestar jolestar added skill::rust Need the rust language skill to complete the issue area::cli CLI relative issues proposal New external API or other notable changes labels Sep 6, 2024
@jolestar jolestar added this to the Rooch v0.8 milestone Sep 6, 2024
@feliciss
Copy link
Collaborator

I can handle this issue.

feliciss pushed a commit to feliciss/rooch that referenced this issue Sep 16, 2024
[rooch-networkgh-2589] add signators as file suffix.
8750973
@feliciss feliciss mentioned this issue Sep 16, 2024
Merged
feliciss pushed a commit to feliciss/rooch that referenced this issue Sep 16, 2024
[rooch-networkgh-2589] add signatories as file suffix.
5e5b048
feliciss pushed a commit to feliciss/rooch that referenced this issue Sep 17, 2024
[rooch-networkgh-2589] remove count and add signatory suffix to file.
20829f4
feliciss pushed a commit to feliciss/rooch that referenced this issue Sep 17, 2024
[rooch-networkgh-2589] remove count and add signatory suffix to file.
94a0d3c
jolestar pushed a commit that referenced this issue Sep 17, 2024
@feliciss
[gh-2589] add signatories as file suffix. (#2641)
67a5e35 
* [gh-2589] add signatories as file suffix.

* [gh-2589] remove count and add signatory suffix to file.

---------

Co-authored-by: Feliciss <10203-feliciss@users.noreply.0xacab.org>
@github-project-automation github-project-automation bot moved this to Done in Rooch Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@feliciss feliciss

Labels
area::cli CLI relative issues proposal New external API or other notable changes skill::rust Need the rust language skill to complete the issue
Projects
Rooch
Status: Done
Milestone
Rooch v0.8
Development

Successfully merging a pull request may close this issue.

[gh-2589] add signatories as file suffix. feliciss/rooch
2 participants
@jolestar @feliciss