[gh-2589] add signatories as file suffix. #2641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
feliciss
requested review from
jolestar,
baichuan3,
wow-sven and
pause125
as code owners
jolestar
reviewed
Sep 16, 2024
| match self { | ||
| FileOutputData::RoochTransactionData(_) => 1, | ||
| FileOutputData::SignedRoochTransaction(_) => 1, | ||
| FileOutputData::PartiallySignedRoochTransaction(data) => data.signators(), |
There was a problem hiding this comment.
Only put the count suffix to psrt? The count of rtd and srt means less.
There was a problem hiding this comment.
Only put the count suffix to psrt? The count of rtd and srt means less.
The description of the issue only mentioned the psrt file.
Okay. I'll also put suffix to others.
There was a problem hiding this comment.
I've fixed it now.
jolestar
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add signatories to each file suffix.
psrtwith multiple signatories, others with one signatory.