Removing a provider breaks Acorn until removing the packages cache

[retlehs]

Adding and then removing a service provider breaks Acorn until the packages cache is removed:

1. composer require spatie/laravel-ignition
2. wp acorn package:discover
3. composer remove spatie/laravel-ignition

Error:

In Application.php line 354:

  Skipping provider [Spatie\LaravelIgnition\IgnitionServiceProvider] because it does not exist.

Workaround:

1. rm cache/acorn/framework/cache/packages.php
2. wp acorn optimize

[yCodeTech]

Can we get this fixed ASAP please. I'm pretty sure wp acorn optimize:clear should remove all files in the cache including the packages.php and services.php, currently it doesn't remove those files. This needs resolving.

[dsturm]

Hej @yCodeTech, please feel free to open a PR on this, so one can review it.

[yCodeTech]

@dsturm I'm not skilled in this type of development, so I can not fix it and submit a pr.

[chrillep]

did some digging and laravels default method is not invoking a new Process of the command via cli. Its removing the cache files in the same instance.

https://github.com/laravel/framework/blob/e217dca49e20cd2840970f8d307c8392012bc5be/src/Illuminate/Foundation/ComposerScripts.php#L48-L69

While acorn is initiating new Process of wp acorn cli command. It fails returning exit code 1. Since the Provider may have been removed when executing.

acorn/src/Roots/Acorn/ComposerScripts.php

Line 21 in b020038

$console->clearCompiled();

acorn/src/Roots/Acorn/Console/Console.php

Lines 9 to 17 in b020038

	/**
	* Execute acorn clear-compiled command.
	*
	* @return int
	*/
	public function clearCompiled(): int
	{
	return $this->acorn('clear-compiled');
	}

acorn/src/Roots/Acorn/Console/Console.php

Lines 99 to 110 in b020038

	/**
	* Execute acorn command.
	*
	* @param array $command
	* @return int
	*/
	public function acorn($command): int
	{
	$command = array_merge($this->findWpCli(), ['acorn'], (array) $command);
	return $this->getProcess($command)->run();
	}

Possible solution.

Reuse laravels method and make sure

getCachedConfigPath() resolves to
{projectpath}/storage/framework/cache/config.php

getCachedServicesPath() resolves to
{projectpath}/storage/framework/cache/services.php

getCachedPackagesPath() resolves to
{projectPath}/storage/framework/cache/packages.php

instead of
{projectpath}/bootstrap/cache/config.php
{projectpath}/bootstrap/cache/services.php
{projectPath}/bootstrap/cache/packages.php

/src/Roots/Acorn/ComposerScripts.php

<?php

namespace Roots\Acorn;

use Illuminate\Foundation\ComposerScripts as FoundationComposerScripts;

class ComposerScripts extends FoundationComposerScripts
{
    /**
     * Clear the cached Laravel bootstrapping files.
     *
     * @return void
     */
    protected static function clearCompiled()
    {
        $laravel = new \Roots\Acorn\Application(getcwd(), ['bootstrap' => getcwd() .'/storage/framework']);
        
        if (is_file($configPath = $laravel->getCachedConfigPath())) {
            @unlink($configPath);
        }

        if (is_file($servicesPath = $laravel->getCachedServicesPath())) {
            @unlink($servicesPath);
        }

        if (is_file($packagesPath = $laravel->getCachedPackagesPath())) {
            @unlink($packagesPath);
        }

    }
}