#270 Removing a provider breaks Acorn until removing the packages cache

[chrillep]

fixes #270

• tested on radicle

• needs more testing in other contexts

did some digging and laravels default method is not invoking a new Process of the command via cli. Its removing the cache files in the same instance.

https://github.com/laravel/framework/blob/e217dca49e20cd2840970f8d307c8392012bc5be/src/Illuminate/Foundation/ComposerScripts.php#L48-L69

While acorn is initiating new Process of wp acorn cli command. It fails returning exit code 1. Since the Provider may have been removed when executing.

acorn/src/Roots/Acorn/ComposerScripts.php

Line 21 in b020038

$console->clearCompiled();

acorn/src/Roots/Acorn/Console/Console.php

Lines 9 to 17 in b020038

	/**
	* Execute acorn clear-compiled command.
	*
	* @return int
	*/
	public function clearCompiled(): int
	{
	return $this->acorn('clear-compiled');
	}

acorn/src/Roots/Acorn/Console/Console.php

Lines 99 to 110 in b020038

	/**
	* Execute acorn command.
	*
	* @param array $command
	* @return int
	*/
	public function acorn($command): int
	{
	$command = array_merge($this->findWpCli(), ['acorn'], (array) $command);
	return $this->getProcess($command)->run();
	}

Possible solution.

Reuse laravels method and make sure

getCachedConfigPath() resolves to
{projectpath}/storage/framework/cache/config.php

getCachedServicesPath() resolves to
{projectpath}/storage/framework/cache/services.php

getCachedPackagesPath() resolves to
{projectPath}/storage/framework/cache/packages.php

instead of
{projectpath}/bootstrap/cache/config.php
{projectpath}/bootstrap/cache/services.php
{projectPath}/bootstrap/cache/packages.php

[QWp6t]

Thanks for the PR! 🙏

I haven't tested this, but I noticed an issue with your approach. Let me know if you want me to jump in and help get this over the finish line or if you prefer to tackle it.

[chrillep]

Thanks for the PR! 🙏

I haven't tested this, but I noticed an issue with your approach. Let me know if you want me to jump in and help get this over the finish line or if you prefer to tackle it.

Yeah that would be great! You jump in and get it over the finish line. 😀

I just wanted to get the ball rolling with what I found.

[chrillep]

@QWp6t Sry ping 😂

[chrillep]

@QWp6t Sry ping again

[retlehs]

This PR doesn't work for me 👀 Steps tested on a regular Bedrock install:

1. composer require roots/acorn
2. composer require roots/acorn-prettify
3. wp acorn optimize:clear
4. Pull in the changes from this PR
5. composer remove roots/acorn-prettify
6. wp acorn

Skipping provider [Roots\AcornPrettify\AcornPrettifyServiceProvider] because it does not exist.

[QWp6t]

LGTM!